Skip to content

Discover subpackage versions dynamically (ticket-015) - #21

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/015-align-logic2code-logic2test-and-lolm-versions-with-their-pyproject
Nov 19, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/015-align-logic2code-logic2test-and-lolm-versions-with-their-pyproject

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

Fixes #20. logic2code, logic2test and lolm all declared __version__ = "1.0.51", while their pyproject.toml declare 0.1.9, 0.1.10 and 0.1.10. The two gates disagree on which value is correct:

  • the installed 0.20.92 gate requires the literals to equal the root VERSION;
  • the new-project 0.20.162 gate requires the enclosing pyproject.toml version, and its GOV-VERSION-001 blocks the fleet standard adoption.

No literal can satisfy both. Each package now resolves __version__ from installed distribution metadata and falls back to its sibling pyproject.toml in a source checkout, which is the dynamic discovery both gates' remediation recommends.

Verification

  • Version resolution: logic2code 0.1.9, logic2test 0.1.10, lolm 0.1.10.
  • ./project/governance-check.sh --base origin/main: GOV-PASS.
  • wellman-governance check (0.20.162 runtime): no GOV-VERSION-001.

🤖 Generated with Claude Code

logic2code, logic2test and lolm declared __version__ = 1.0.51 while their
pyproject.toml declare 0.1.9, 0.1.10 and 0.1.10. The installed 0.20.92 gate
wants the root VERSION and the 0.20.162 gate wants the enclosing pyproject,
so no literal satisfies both. Resolve the version from installed metadata,
falling back to the sibling pyproject.toml in a source checkout.

Fixes #20

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51.

Ticket: ticket-015
Correlation ID: local-semcod-code2logic-pr-21-ticket-015
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The change safely replaces conflicting hard-coded package versions with standard installed-distribution metadata lookup and a bounded source-checkout fallback to each package's sibling pyproject.toml. The visible implementation matches the stated remediation, introduces no evident security defect, and required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 34d6a5f9f68b654c6d5c2e36145a014fc6d384fe...b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51
Change digest: 972c2d816c4baf7b65a978fa6ac4ad2486d4738fd4a865e2269cc2c1f61c38c5
Score: 64/100 (L), estimated 78 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":95,"base_sha":"34d6a5f9f68b654c6d5c2e36145a014fc6d384fe","binary_files":0,"categories":{"code":3,"configuration":1,"docs":2},"change_digest":"972c2d816c4baf7b65a978fa6ac4ad2486d4738fd4a865e2269cc2c1f61c38c5","comparison":"34d6a5f9f68b654c6d5c2e36145a014fc6d384fe...b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51","deletions":3,"file_count":6,"files":["logic2code/__init__.py","logic2test/__init__.py","lolm/__init__.py","project/TICKETS.md","project/ticket-015/README.md","project/ticket-015/intent.json"],"head_sha":"b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":3,"scope":4,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":78,"within_budget":false},"impact":{"components":["claude.com","logic2code","logic2test","lolm","origin","project"],"files":["claude.com/claude-code","logic2code/__init__.py","logic2test/__init__.py","lolm/__init__.py","origin/main","project/TICKETS.md","project/governance-check.sh","project/ticket-015/README.md","project/ticket-015/intent.json"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":12,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":12,"name":"Implement logic2code","scope":["logic2code"]},{"estimated_minutes":12,"name":"Implement logic2test","scope":["logic2test"]},{"estimated_minutes":12,"name":"Implement lolm","scope":["lolm"]},{"estimated_minutes":12,"name":"Implement origin","scope":["origin"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-015"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-015: Discover subpackage versions dynamically (ticket-015)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,30 105,51 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 78m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-015-2113
TICKET ticket-015
HEAD_SHA b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51
CORRELATION_ID local-semcod-code2logic-pr-21-ticket-015
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Publish logic2code=SKIPPING","Publish logic2test=SKIPPING","Publish lolm=SKIPPING","test (3.13)=PASS","test (3.11)=PASS","Test logic2test (3.12)=FAIL","Test logic2code (3.11)=FAIL","test (3.12)=PASS","governance / remote lifecycle=PASS","Test lolm (3.11)=FAIL","Test logic2code (3.10)=FAIL","Test logic2code (3.9)=FAIL","Test lolm (3.10)=FAIL","Test logic2test (3.10)=FAIL","Test lolm (3.9)=FAIL","Test lolm (3.12)=FAIL","Test logic2test (3.11)=FAIL","Test logic2test (3.9)=FAIL","Test logic2code (3.12)=FAIL","governance / enforce=PASS","test (3.12)=PASS","test (3.11)=PASS","test (3.13)=PASS"]
INPUT required_checks = ["test (3.11)","test (3.12)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/code2logic","pull_request":21,"head_sha":"b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51","base_sha":"34d6a5f9f68b654c6d5c2e36145a014fc6d384fe","diff_sha256":"5058b7a5c3590b1b2f88287418b32f489a59683964d77e0fc12b0d94d5b39a4b"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["logic2code/__init__.py","logic2test/__init__.py","lolm/__init__.py","project/TICKETS.md","project/ticket-015/README.md","project/ticket-015/intent.json"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"34d6a5f9f68b654c6d5c2e36145a014fc6d384fe","head_sha":"b2470bf5460bbd8ba90eb21ac53be1ea6d9b1d51","change_digest":"972c2d816c4baf7b65a978fa6ac4ad2486d4738fd4a865e2269cc2c1f61c38c5","score":64,"complexity":"L","estimated_minutes":78,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 9743270 into main Nov 19, 2026
11 of 23 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/015-align-logic2code-logic2test-and-lolm-versions-with-their-pyproject branch November 19, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align declared versions so the new-project 0.20.162 gate passes

1 participant