Repository navigation
docs: Fix Java SDK broken sample links, stale version, and samples README - #441
promptless[bot] wants to merge 5 commits into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 249 249
Lines 8799 8799
Branches 1268 1268
=======================================
Hits 8129 8129
Misses 446 446
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
…eview # Conflicts: # docs/api_reference.md # skyvault/README.md # skyvault/samples/README.md
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
…eview # Conflicts: # skyvault/README.md
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
Blocked — one thing needed from you The Check Commit Message check failed on commit e67ae6f because of how this suggestion's commits were written, not because of the docs content or Need: The Jira ticket key this docs work should use. Reply in a comment on this PR. Next: We'll add the key to the PR title, replace the branch history with a single commit that starts with the key, and force-push the branch. The file contents stay the same, and the check should pass after that. |
Open in Promptless
Why
Splitting the repo into
common/,skyvault/, andflowvault/(b3cf737) left many links pointing at root-levelsamples/,src/, andREADME.mdpaths that no longer exist. The install snippet also pins an old version.Goal
skyvault/README.md: point 24 broken sample and source links at their currentskyvault/andcommon/paths. Change the install version from 2.0.0 to 2.1.1 to matchskyvault/pom.xmland add a Maven Central pointer.docs/api_reference.mdanddocs/migrate_to_v2.md: link toskyvault/README.mdinstead of the root README, which is now a package picker.skyvault/samples/README.md: rewrite it to describe the samples that exist now.flowvault/README.md: add a minimalbulkInsertcall to the Quickstart, which previously built a client and never used it.InsertRequest.homogeneousdefault versus its behavior on batch requests needs a product decision, and the SDK versions in the samples'pom.xmlfiles are stale.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events