Repository navigation
Keep a user's corpora in the state directory when the registry is shipped - #20
Merged
Merged
Conversation
…pped In a container the registry is part of the image and the session's user cannot write it. Opening SPEAR on a tree the image does not know offered to register its sub-trees, then died on the write. What a session adds now goes to projects.json in the state directory, which is read along with the shipped registry; the shipped entry wins on a name. An install whose state directory is the install itself behaves as before.
The test asserts what happens when nothing can be written. With a state directory there is now somewhere to write, and the shared test state kept the corpus for the tests that followed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening
spear-chatin the container on a tree the image does not know offered to register its sub-trees and then exited withcannot write the corpus registry (/opt/spear/client/projects.json): Permission denied.The registry now has a second, user-owned file:
projects.jsonin the state directory. It is written when the shipped one cannot be, and read along with it (the shipped entry wins on a name).Checked in the container on a seven-component workspace: the components are registered, the file lands in the state volume, the session opens. Tests added; the suite passes.