Repository navigation
Handle incomplete syntax trees through parser error recovery - #132
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed Solidity can leave required ANTLR children missing.
parse()currently visits that incomplete tree before checking syntax errors, so callers get an internalTypeErrorinstead ofParserError.Check diagnostics before building the AST in strict mode. In tolerant mode, keep declarations that can be built and omit a top-level declaration whose recovered tree cannot be converted; return the diagnostics and requested metadata as usual. Recovery is enabled only when syntax errors were actually reported, so AST errors on syntactically valid input still propagate. Document the omission behavior.
Fixes #131.
Validation on Windows / Node.js 24: 11 new regression cases fail on the original source and the valid-input error control passes. With the fix, all 193 Node tests, 3 bundle integration tests, and the headless Chrome browser test pass. ESLint, TypeScript checks, Prettier on changed files, Node/browser bundle builds, and
git diff --checkpass. The existing generated grammar is unchanged; the ANTLR generator was not rerun.