Repository navigation
fix: draw the SQLLoad and Fensu card icons as large as the others - #16
Merged
Merged
Conversation
Their wide marks drew at 52x32 and 52x28 in the shared 52px box. Give them 60px and 64px boxes centred on the same column so each covers about the same area as the squarer marks.
Deploying sqlstack with
|
| Latest commit: |
c75aaa8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a17d8e6a.sqlstack.pages.dev |
| Branch Preview URL: | https://fix-product-icon-sizes.sqlstack.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLLoad's and Fensu's marks are wide (about 1.65:1 and 1.87:1), so in the shared 52px icon box they drew at 52×32 and 52×28, noticeably lighter than SQLBuild (45×52), SQLClean (52×44) and SQLQuack (52×43).
Validation:
npm testpasses (4/4). Checked light and dark at 320, 390, 768, 1000, 1200 and 1536px: no horizontal overflow, and at least 14px between each icon and its title.