Repository navigation
test(marketplace): pin 27's acceptance — --domain reaches the generated file (27) - #358
Merged
Merged
Conversation
…ed file BUGS.md #27 is implemented by PR 336 (merged 2026-11-13): install writes its flags into the stacker.yml it generates for server-held templates — --domain/--set into install.inputs, --key/--key-id/--provider/--region/ --size into deploy.cloud, with a stderr note naming any flag it could not write. The entry's acceptance line ("a value passed to --domain appears in the generated file") had no direct test at the file level; this pins it. Co-Authored-By: Claude Opus 5 <noreply@claude.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BUGS.md #27:
stacker install --domain/--region/--size/--keyaccepted flags and dropped them silently — the generatedstacker.ymlkept the template defaults, so the operator believed the domain was set and found out when TLS or the webhook URL was wrong.The fix itself landed in PR 336 (merged 2026-11-13): install now writes its flags into the file it generates for server-held templates —
--domain/--setintoinstall.inputs,--key/--key-id/--provider/--region/--sizeintodeploy.cloud(creating the block when a provider is given), with a stderr note naming any flag it could not write.This PR
Closes the loop on the entry:
--domainappears in the generated file") gets a direct file-level regression test (install_domain_appears_in_the_generated_file) — the chain--domain→install.inputs→ written YAML is now pinnedTests
New test green against current dev (it pins existing behaviour — PR 336's implementation); marketplace install/inputs suite passes. Full suite otherwise unchanged except the pre-existing flaky
tests/agent_sweep.rs.