Skip to content

test(marketplace): pin 27's acceptance — --domain reaches the generated file (27) - #358

Merged
vsilent merged 2 commits into
devfrom
fix/install-domain-into-file-27
Nov 20, 2026
Merged

vsilent merged 2 commits into
devfrom
fix/install-domain-into-file-27

Conversation

@vsilent

@vsilent vsilent commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

What

BUGS.md #27: stacker install --domain/--region/--size/--key accepted flags and dropped them silently — the generated stacker.yml kept the template defaults, so the operator believed the domain was set and found out when TLS or the webhook URL was wrong.

The fix itself landed in PR 336 (merged 2026-11-13): install now writes its flags into the file it generates for server-held templates — --domain/--set into install.inputs, --key/--key-id/--provider/--region/--size into deploy.cloud (creating the block when a provider is given), with a stderr note naming any flag it could not write.

This PR

Closes the loop on the entry:

  • the acceptance line ("a value passed to --domain appears in the generated file") gets a direct file-level regression test (install_domain_appears_in_the_generated_file) — the chain --domain → install.inputs → written YAML is now pinned
  • BUGS.md Issue auth #27 marked fixed, citing PR 336, with How-to-verify steps

Tests

New test green against current dev (it pins existing behaviour — PR 336's implementation); marketplace install/inputs suite passes. Full suite otherwise unchanged except the pre-existing flaky tests/agent_sweep.rs.

robotizeit and others added 2 commits November 20, 2026 10:30
…ed file

BUGS.md #27 is implemented by PR 336 (merged 2026-11-13): install writes
its flags into the stacker.yml it generates for server-held templates —
--domain/--set into install.inputs, --key/--key-id/--provider/--region/
--size into deploy.cloud, with a stderr note naming any flag it could not
write. The entry's acceptance line ("a value passed to --domain appears in
the generated file") had no direct test at the file level; this pins it.

Co-Authored-By: Claude Opus 5 <noreply@claude.com>
@vsilent
vsilent merged commit 04bc200 into dev Nov 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants