Repository navigation
Conversation
…nts (39) The validator scanned raw text, so a variable that appears exclusively inside a YAML comment failed the whole stack — and every pipeline gating on `stacker secrets validate` with it. References are now collected from parsed scalars (keys and values), which drops comments naturally while still counting block-scalar content where '#' is literal text; unparseable YAML falls back to the old raw scan. Co-Authored-By: Claude Opus 5 <noreply@claude.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BUGS.md #39:
stacker secrets validatescanned raw text, so a${VAR}that appears only inside a YAML comment failed the whole stack — and every pipeline gating on the command with it (exit 1).How
References are collected from parsed YAML scalars (keys and values): comments drop out naturally, while block-scalar content — where
#is literal text — still counts. Unparseable YAML falls back to the old raw scan.Tests
Red→green (red reproduced the entry's exact
BASE_PATHfailure): comment-only references are ignored, block-scalar content is still checked, the fallback keeps working. The old test suite is untouched and green.Verify
In BUGS.md #39 ("How to verify"): a
# ${BASE_PATH}/...comment alone must leavestacker secrets validateat exit 0.