Repository navigation
Fix $try, custom function errors and crashes - #421
Open
Daaisukidayo wants to merge 10 commits into
Open
Daaisukidayo wants to merge 10 commits into
Daaisukidayo wants to merge 10 commits into
Conversation
… JSON functions and crashes in $advancedBar, $setChannelArchiveDuration, websocket callbacks and $await filters
…sers, fixed ArgType.Invite, ArgType.URL, buffer functions and $entitlementConsume
Contributor
Author
|
… errors inside the function, $arrayMap ignoring errors in the other variable field, $get and $has returning values for names like toString, and variables and local functions named __proto__ not working
…hown in the channel, the silent operator on custom functions still logging them to the console, and $eval inside custom functions logging its errors twice
…nside custom functions, $break and $continue within custom functions now affect loop in the calling code
Member
|
Your changes will be reviewed soon! There will be changes on how and where pull requests are merged into the codebase, more info on this will follow... |
xNickyDev
requested changes
Nov 20, 2026
xNickyDev
left a comment
Member
There was a problem hiding this comment.
First review for suggested changes. Will review the other files soon with Aggelos.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$trycatches raw exceptions and runs catch only on errors, including silent ones.$stop,$break,$continueand$returnpass through it$stop,$breakand$continuecome back to the caller.$tryand the silent operator work around custom functions,$#returnworks inside them,$breakand$continueaffect the caller's loop$trycan read it$callLocalFunctionpasses errors,$stop,$breakand$continueup instead of returning them as text$setTimeout,$setInterval,$async,$wsOn,$wsSendand the filters of$awaitMessage,$awaitComponentand$awaitModalSubmitlog errors to console instead of losing them or crashing$getand$hasno longer return values for names like toString, proto works as a normal name$advancedBarhanging on negative or fractional length, length is capped at 4096$setChannelArchiveDurationcrashing on API errors and always returning truehttp://links$bufferLength,$bufferReadInt32,$bufferReadUtf8and$bufferToStringalways returning nothing$entitlementConsumenot accepting its argument and returning a promise instead of bool$setInviteTargetUsers,$updateInviteTargetUsersand the roles invite property