Repository navigation
Add AMD Versal Gen 2 (VEK385) target - #992
night1rider wants to merge 3 commits into
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .gitignore, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.ld, lib/wolfHAL, options.mk, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/board/mk_board_dtb.sh, tools/scripts/versal2/board/ospi_tool/Makefile, tools/scripts/versal2/board/ospi_tool/ospi_tool.ld, tools/scripts/versal2/board/ospi_tool/start.S, tools/scripts/versal2/board/program_jtag.tcl and 2 more
Coverage: 5 of 7 in-scope changed file(s) opened by the reviewer; not opened: hal/boards/stm32wba55cg_nucleo/wolfHAL_board.c, test-app/app_versal2.c
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Max
e3bb7e9 to
ee81ae1
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .github/workflows/test-external-library-paths.yml, .gitignore, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.ld, lib/wolfHAL, options.mk, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/board/mk_board_dtb.sh, tools/scripts/versal2/board/ospi_tool/Makefile, tools/scripts/versal2/board/ospi_tool/ospi_tool.ld, tools/scripts/versal2/board/ospi_tool/start.S and 3 more
Coverage: 1 of 3 in-scope changed file(s) opened by the reviewer; not opened: tools/scripts/versal2/board/ospi_tool/ospi_tool.c, tools/unit-tests/unit-wolfhal-ext-flash.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
ee81ae1 to
32a814a
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .github/workflows/test-external-library-paths.yml, .gitignore, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.ld, lib/wolfHAL, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/board/mk_board_dtb.sh, tools/scripts/versal2/board/ospi_tool/Makefile, tools/scripts/versal2/board/ospi_tool/ospi_tool.ld, tools/scripts/versal2/board/ospi_tool/start.S, tools/scripts/versal2/board/program_jtag.tcl and 2 more
Coverage: 3 of 8 in-scope changed file(s) opened by the reviewer; not opened: hal/boards/stm32wba55cg_nucleo/wolfHAL_board.c, hal/boards/vek385/wolfHAL_board.c, src/boot_aarch64.c, test-app/app_versal2.c, tools/scripts/versal2/board/ospi_tool/ospi_tool.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
8ea9cee to
2ab0b04
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .github/workflows/test-external-library-paths.yml, .gitignore, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.ld, lib/wolfHAL, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/board/mk_board_dtb.sh, tools/scripts/versal2/board/ospi_tool/Makefile, tools/scripts/versal2/board/ospi_tool/ospi_tool.ld, tools/scripts/versal2/board/ospi_tool/start.S, tools/scripts/versal2/board/program_jtag.tcl and 2 more
Coverage: 1 of 4 in-scope changed file(s) opened by the reviewer; not opened: hal/boards/vek385/wolfHAL_board.c, tools/scripts/versal2/board/ospi_tool/ospi_tool.c, tools/unit-tests/unit-wolfhal-ext-flash.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
2ab0b04 to
53428a1
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .github/workflows/test-external-library-paths.yml, .gitignore, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.ld, lib/wolfHAL, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/mk_board_dtb.sh, tools/scripts/versal2/program_jtag.tcl, tools/scripts/versal2/versal2_boot.bif, tools/unit-tests/Makefile
Coverage: 2 of 7 in-scope changed file(s) opened by the reviewer; not opened: hal/boards/stm32wba55cg_nucleo/wolfHAL_board.c, hal/boards/vek385/wolfHAL_board.c, src/boot_aarch64.c, test-app/app_versal2.c, tools/unit-tests/unit-wolfhal-ext-flash.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
9e84fd9 to
c884123
Compare
TARGET=versal2 runs at EL2 after BL31 as a wolfHAL board (BOARD=vek385). hal/wolfhal.c gains ext_flash_* with a partition guard. Configs and docs.
Resets the flash out of the PLM's octal DDR mode at init. Adds the JTAG BIF and script, the Linux DTB script and FIT source, and the board docs.
Host unit tests for the ext_flash code and partition guard, uart_write and the internal flash calls of hal/wolfhal.c, on mock wolfHAL devices.
c884123 to
5290e9c
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #992
Scan targets checked: wolfboot-src, wolfboot-bugs
Not reviewed (no scan target covers them): .github/workflows/test-configs.yml, .github/workflows/test-external-library-paths.yml, .gitignore, Makefile, arch.mk, config/examples/versal2_vek385.config, config/examples/versal2_vek385_linux.config, docs/HAL.md, docs/Targets.md, docs/wolfHAL.md, hal/boards/vek385/board.mk, hal/boards/vek385/wolfHAL_board.h, hal/versal2.h, hal/versal2.its, hal/versal2.ld, lib/wolfHAL, src/boot_aarch64_start.S, test-app/Makefile, tools/scripts/versal2/mk_board_dtb.sh, tools/scripts/versal2/program_jtag.tcl and 2 more
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: test-app/app_versal2.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Adds wolfBoot support for the AMD Versal Gen 2 VEK385 board as a new target,
TARGET=versal2.WOLFHAL=1 BOARD=vek385). The UART, OSPI, OSPI DMA and NOR flash drivers come from wolfHAL ([reg, test] Use 32-bit register accesses on all targets wolfHAL#62, [uart, pl011, versal2, test] Add an Arm PL011 UART driver wolfHAL#63, [spimem, flash, cadence_ospi, versal2, test] Add a SPI memory type with Cadence OSPI and NOR flash drivers wolfHAL#64), solib/wolfHALmoves to currentmain.hal/wolfhal.cgetsext_flash_*with a partition guard: program and erase only work inside BOOT, UPDATE and SWAP.program_flash, as for Zynq-7000.ext_flashcode and partition guard,uart_writeand the internal flash calls.test-configs.ymlgets build jobs for the two new configs, plus a no-DMA and an EL1 build.whal_Reg32_*calls of the newer wolfHAL. The STM32WB and STM32WBA wolfHAL builds still pass.