Repository navigation
Improve retrieval and fetch in the docs MCP sample - #214
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 940a56df03
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Review fixes are published in |
|
Exact-head CI is now green for |
|
@codex review please |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29780a88fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
autocarl
left a comment
There was a problem hiding this comment.
Addressed the new scoped-console continuation finding in e10620a. Narrow two-file correction: explicit root-scope instructions for both continuation commands, with both ANSI rendering regressions observed RED then GREEN (2/2). Release warning-as-error build passed. No routing/API change, no merge, and no bot re-review triggered. New-head CI is pending; prior green results remain scoped to 29780a8.
|
Exact-head CI is green for the scope-hint fix |
|
@codex another review please |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Addresses the eight improvements in #213, keeping the implementation local to the sample. No new packages, service layers, retained snapshots, background jobs, or retrieval framework.
docs fetch --offset/ MCPoffset,nextOffset, and a same-headingnextId. A small sample-specific helper handles bounded UTF-16 pages. Each call still reads the current generation; callers restart if it changes. This is not a snapshot protocol.Closes #213.
Verification
With the pinned assets fetched and
DOCS_TEST_ASSETSpointing to that directory:dotnet build src/Repl.DocsSampleTests/Repl.DocsSampleTests.csproj -c Release -f net10.0 -m:1 --disable-build-servers -p:UseSharedCompilation=false -nr:false -warnaserror— zero warnings/errors.net11.0— zero warnings/errors.dotnet src/Repl.DocsSampleTests/bin/Release/net10.0/Repl.DocsSampleTests.dll --progress off --report-trx— 105 passed, 0 failed, 0 skipped.net11.0— 105 passed, 0 failed, 0 skipped. These include the real ONNX reference vectors/tokenizer, native SQLite, HTTP MCP parameter descriptions and offset binding, pipes/WebSockets, lossless >20k document reconstruction, sibling boundaries, cancellation, and unchanged-source warm-index invalidation.MarkdownCorpus.EmbeddingTexthelper fails 10 of the 15 parser cases; the old index implementation fails the contextual-input and fetch-continuation tests; old readiness/schema behavior fails the two added worker regressions.Majorroll-forward.git diff --cached --checkand added-line security scan passed.Local native verification was on Linux x64. Windows/macOS and the Docker image remain for the existing CI workflow; this PR does not change CI policy. Split code blocks retain raw source fragments rather than inventing repaired Markdown fences. Ancestor-heading context and durable multi-request snapshots are intentionally not added.
Review follow-up (
29780a8)JsonDocument, not a producer DTO.string.Concat(prefix, text.AsSpan(...)); whitespace-only fragments are not indexed. LF/CRLF regression cases failed before the correction.29780a8is green: the main CI and Documentation sample workflows succeeded, including Windows/Linux/macOS native tests and container checks. The release job is intentionally skipped on this PR.