Repository navigation
chore: follow-ups from the #22 approvals - #24
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Merge Risk:
|
|
Review submitted The automated review has been submitted. See the review for the verdict and any findings. Head: |
jervasion-absmartly
left a comment
There was a problem hiding this comment.
✅ Approved
This follow-up updates the agent-version Javadoc examples to 1.9.0 and removes redundant comments. Executable code, test setup and assertions remain unchanged; no blocking issue remains.
Next step: None — ready to merge.
What I checked
- ✅ Both Javadoc examples match the build's 1.9.0 SDK version. All 16 comment blocks identified in the earlier approval are removed without changing behavior.
- ✅ Local compilation, packaging, Animal Sniffer and JaCoCo verification pass. Both artifacts pass on JDK 11 and JDK 25: 2,430 test executions, zero failures, errors or skips.
- ✅ Exact-head CI passes the full clean build, including formatting. Local Spotless provisioning hit an Eclipse download DNS failure; passing CI supplies that evidence.
Review details
Round 1. Head: c066ba999277dcfcc7971fd210915434abb6f791. Base, merge-base and responsibility baseline: 853feb3716ca8428cd76212302239fdcd1df01ed. Final PR fetch confirmed unchanged head/base.
Read the PR description, both commits, complete five-file diff, conversation, reviews and inline comments, linked #22 approvals, README compatibility/version guidance, shared build configuration and CI workflow. No AGENTS.md or CLAUDE.md exists. Declared and actual scope agree: two Javadoc replacements and removal of 21 comment lines across Context and three test files. No public contract or rollout change, material customer-state inference or unknown is needed. The author's bytecode-equivalence report was not treated as independently executed evidence; the complete diff directly shows comment-only changes.
Validation:
- Verified Java and javac 11.0.33.
JAVA_HOME=${JAVA_HOME_11} ./gradlew -Porg.gradle.java.installations.paths=${JAVA_HOME_25} clean buildcould not provision the Eclipse formatter because download.eclipse.org failed DNS resolution. JAVA_HOME=${JAVA_HOME_11} ./gradlew -Porg.gradle.java.installations.paths=${JAVA_HOME_25} clean build -x spotlessCheckpassed. XML totals: core-api test/testJdk25 each 607; core-api-java6 test/testJdk25 each 608; zero failures/errors/skips. Compilation, jars, example packaging, Animal Sniffer and coverage verification passed.- Exact-head Actions run 43972503520, build job 133668014372: completed/success. Workflow runs
./gradlew -Porg.gradle.java.installations.fromEnv=JAVA_HOME_25_X64 clean build, formatting included. Runs/jobs and commit-status APIs checked; no commit statuses are posted (the empty aggregate is not a pending job). No material unfinished check identified. git diff --check 853feb3 HEADpassed. Pinned introduced_blobs.py completed: five content writes across two commits, all corresponding to the intentional five source paths. Content and diffs inspected; no credential, scratch artifact or historical-only file found.
Passes (non-blocking): run: documentation correctness (version examples and removed prose), tests/CI/packaging (three test files touched, shared generation and build checked), cross-cutting simplicity, comment hygiene, diff composition. Not run: core runtime/API/security/data (no executable change); dedicated error specialist (only comments/Javadoc, no changed failure behavior or messages); deployment/operations/observability (no manifests, operational procedures or telemetry changes); shared-component/frontend blast radius (no frontend files); behavior-bearing data/policy (no consumed configuration, fixtures or policies changed). Small comment-only scope audited locally; no independent specialist pass triggered.
Comment hygiene (non-blocking): 2 comment / 0 code lines, ratio n/a; none flagged.
threshold T=5; restatements counted: yes (10 × C ≥ E).
Both added lines are one-line public-method documentation, preserved by the documentation-string exemption. All five Java paths are source-class; no countable code added.
Diff composition (non-blocking): every file is required for the change; none flagged.
Simplifications (non-blocking): none. No construct or machinery introduced.
Final independent sdk-review on c066ba9: APPROVEIndependent sdk-review on c066ba9: APPROVE, 0 P1/P2 fixed across 1 reviewer pass. A fresh subagent ran the sdk-review skill read-only on the full diff
Two notes the reviewer raised that are not findings for this PR: the CHANGELOG heading Full reviewer report and evidence log (head c066ba9)APPROVE at Compared Maven Central Must fixNone. Tests needed (current implementation correct)15 full-suite mutations on the system-attribute and publish code that the de-commented tests cover: 15 killed, 0 survived. Each of the 16 removed comments described a test whose assertions still kill the matching mutant (see the evidence log, step 4). Compatibility / parity / forward-compat evidence
PerformanceNot applicable: the bytecode is identical. No timing claimed. P3 / notes
Version and release notes
Pre-existing on main (not this PR)
Verification limits / provenance: Spotless could not run locally (download.eclipse.org does not resolve). CI run 43972503520 on head sdk-review evidence: #24
1. Trees
2. Backwards compatibility
3. Parity
4. Tests and mutation
5. Performance
6. Forward compatibility
7. Build / CI
8. Docs / CHANGELOG
Findings
Verification limits
🤖 Generated with Claude Code |
marcio-absmartly
left a comment
There was a problem hiding this comment.
APPROVE. Reviewed the complete diff at c066ba9992. The only non-comment text changes update the Javadoc version examples from 1.7.0 to 1.9.0; all other edits remove explanatory comments. No executable code, signatures, test assertions or fixtures change. This closes the comment/version-example follow-ups without affecting the prior SDK review's behaviour or compatibility conclusions.
Validation: complete source diff review; GitHub build is green on this head. I did not rerun the suite locally for this comment/Javadoc-only change.
Takes main's #24 follow-ups (restating test comments removed). The 1.x Client agent Javadoc change does not apply: 2.x removed getAgent/getAgentName/getAgentVersion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to #22 (merged as 853feb3): handles the items left in the approving reviews.
Post-merge commits carried over
None. The PR's last head
4ecfd78is fully contained in main:git log origin/main..4ecfd78andgit diff origin/main 4ecfd78are both empty.Approval comments → what was done
Client.javaJavadoc example still saysabsmartly-java-sdk/1.7.0getAgentVersion/getAgentexamples now say 1.9.0 (f460899)toleratesUnknownContextFieldsusesfullOnVariant: 1, so it does not exercise seeds/splits and does not assert theholdout_futureholdoutDefaultContextDataDeserializerTest.ignoresUnknownFieldsAtEveryLevelalready covers both and "this isn't a gap in protection". The HTTP test only has to prove the real HTTP path tolerates unknown fields, and every@JsonIgnorePropertiesremoval is already killed by both tests.Owner decisions (not in this PR)
None were raised in the approving reviews.
Verification
JAVA_HOME=$JAVA_HOME_11 ./gradlew clean build -x spotlessCheck(UTF-8 locale) passes: core-api 607/0 and core-api-java6 608/0 tests, on both JDK 11 and JDK 25, 0 skipped. Animal Sniffer, JaCoCo and the jars pass too. Spotless can't run locally (the sandbox can't resolve download.eclipse.org); CI runs it.javap -p -c -constants(line-number tables ignored) shows main and this branch are bytecode-identical: every production class in both jars and all 81 core-api test classes. So there is no behaviour or API change, and no CHANGELOG entry (nothing customer-visible).🤖 Generated with Claude Code
Summary by CodeRabbit