Skip to content

chore: follow-ups from the #22 approvals - #24

Merged
joalves merged 2 commits into
mainfrom
chore/pr22-approval-follow-ups
Nov 20, 2026
Merged

joalves merged 2 commits into
mainfrom
chore/pr22-approval-follow-ups

Conversation

@joalves

@joalves joalves commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #22 (merged as 853feb3): handles the items left in the approving reviews.

Post-merge commits carried over

None. The PR's last head 4ecfd78 is fully contained in main: git log origin/main..4ecfd78 and git diff origin/main 4ecfd78 are both empty.

Approval comments → what was done

Source Item Outcome
jervasion-absmartly, last approval (optional suggestion) Short comments restating test setup or assertions: ContextAssignmentRulesTest 471, 489; ContextSystemAttributesTest 45–46, 112, 125, 136, 156, 202–203, 230, 255, 267, 278, 292–293; LocalHttpServerIntegrationTest 64, 226–228; Context.java 2058 Removed all 16 flagged blocks (c066ba9). Test names and assertions already say the same thing. The comments that record collector/protocol constraints, locking and the missing-client stub were not flagged and are kept.
marcio-absmartly, last approval No items (unconditional approve) Nothing to do
marcio-absmartly, previous approval (non-blocking) Client.java Javadoc example still says absmartly-java-sdk/1.7.0 Both getAgentVersion/getAgent examples now say 1.9.0 (f460899)
marcio-absmartly, previous approval (non-blocking) toleratesUnknownContextFields uses fullOnVariant: 1, so it does not exercise seeds/splits and does not assert the holdout_future holdout Not changed. Marcio notes that DefaultContextDataDeserializerTest.ignoresUnknownFieldsAtEveryLevel already covers both and "this isn't a gap in protection". The HTTP test only has to prove the real HTTP path tolerates unknown fields, and every @JsonIgnoreProperties removal is already killed by both tests.
marcio-absmartly, previous approval (to fix before merge) Spotless blank lines Already fixed in #22 (40cc2aa)
Inline comments with or after the approvals None posted —

Owner decisions (not in this PR)

None were raised in the approving reviews.

Verification

  • JAVA_HOME=$JAVA_HOME_11 ./gradlew clean build -x spotlessCheck (UTF-8 locale) passes: core-api 607/0 and core-api-java6 608/0 tests, on both JDK 11 and JDK 25, 0 skipped. Animal Sniffer, JaCoCo and the jars pass too. Spotless can't run locally (the sandbox can't resolve download.eclipse.org); CI runs it.
  • javap -p -c -constants (line-number tables ignored) shows main and this branch are bytecode-identical: every production class in both jars and all 81 core-api test classes. So there is no behaviour or API change, and no CHANGELOG entry (nothing customer-visible).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the version shown in the agent-version example from 1.7.0 to 1.9.0.
    • Removed outdated explanatory comments from SDK documentation and tests. These changes do not affect application behaviour.

lux worker and others added 2 commits November 16, 2026 22:35
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The getAgentVersion Javadoc and X-Agent header example now use version 1.9.0 instead of 1.7.0. Comments were removed from Context and from assignment-rule, system-attribute, and HTTP integration tests. The helper, test configurations, assertions, and executable behaviour remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • absmartly/java-sdk#22: This follow-up addresses review concerns about audience evaluation behaviour and app_version from PR #22.

Suggested reviewers: jervasion-absmartly, marcio-absmartly

Merge Risk: Minimal · up to c066b

This PR updates a documentation example and removes redundant comments, with no behavior or API changes. It is safe to merge.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "chore: follow-ups from the #22 approvals" is vague. It names no specific change. The PR removes redundant test comments and updates Javadoc agent-version examples to 1.9.0. The title refers… Replace the title with a description of the main change, for example: "chore: remove redundant test comments and update agent version in Javadoc".
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore: follow-ups from the #22 approvals" is vague. It names no specific change. The PR removes redundant test comments and updates Javadoc agent-version examples to 1.9.0. The title refers to the follow-up nature but does not say what changed, so a teammate scanning history cannot tell the primary change.

Resolution

Replace the title with a description of the main change, for example: "chore: remove redundant test comments and update agent version in Javadoc".

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the version line,
Then clears a comment, neat and fine.
The tests stay still; their checks remain,
No code path shifts, no changed domain.
A quiet diff, a tidy page,
The rabbit hops off stage.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5c08b8f1-a9b0-4c7e-9706-898ff8c84879
Commits

Reviewing files that changed from the base of the PR and between 853feb3 and c066ba9.

Files selected for processing: 5

  • core-api/src/main/java/com/absmartly/sdk/Client.java
  • core-api/src/main/java/com/absmartly/sdk/Context.java
  • core-api/src/test/java/com/absmartly/sdk/ContextAssignmentRulesTest.java
  • core-api/src/test/java/com/absmartly/sdk/ContextSystemAttributesTest.java
  • core-api/src/test/java/com/absmartly/sdk/LocalHttpServerIntegrationTest.java
Files with no reviewable changes: 4

  • core-api/src/main/java/com/absmartly/sdk/Context.java
  • core-api/src/test/java/com/absmartly/sdk/ContextAssignmentRulesTest.java
  • core-api/src/test/java/com/absmartly/sdk/ContextSystemAttributesTest.java
  • core-api/src/test/java/com/absmartly/sdk/LocalHttpServerIntegrationTest.java

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@jervasion-absmartly

jervasion-absmartly commented Nov 16, 2026 •

Copy link
Copy Markdown

Review submitted

The automated review has been submitted. See the review for the verdict and any findings.

Head: c066ba999277 | Updated: 2026-11-16 23:03 UTC

@jervasion-absmartly jervasion-absmartly left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved

This follow-up updates the agent-version Javadoc examples to 1.9.0 and removes redundant comments. Executable code, test setup and assertions remain unchanged; no blocking issue remains.

Next step: None — ready to merge.

What I checked

  • ✅ Both Javadoc examples match the build's 1.9.0 SDK version. All 16 comment blocks identified in the earlier approval are removed without changing behavior.
  • ✅ Local compilation, packaging, Animal Sniffer and JaCoCo verification pass. Both artifacts pass on JDK 11 and JDK 25: 2,430 test executions, zero failures, errors or skips.
  • ✅ Exact-head CI passes the full clean build, including formatting. Local Spotless provisioning hit an Eclipse download DNS failure; passing CI supplies that evidence.
Review details

Round 1. Head: c066ba999277dcfcc7971fd210915434abb6f791. Base, merge-base and responsibility baseline: 853feb3716ca8428cd76212302239fdcd1df01ed. Final PR fetch confirmed unchanged head/base.

Read the PR description, both commits, complete five-file diff, conversation, reviews and inline comments, linked #22 approvals, README compatibility/version guidance, shared build configuration and CI workflow. No AGENTS.md or CLAUDE.md exists. Declared and actual scope agree: two Javadoc replacements and removal of 21 comment lines across Context and three test files. No public contract or rollout change, material customer-state inference or unknown is needed. The author's bytecode-equivalence report was not treated as independently executed evidence; the complete diff directly shows comment-only changes.

Validation:

  • Verified Java and javac 11.0.33. JAVA_HOME=${JAVA_HOME_11} ./gradlew -Porg.gradle.java.installations.paths=${JAVA_HOME_25} clean build could not provision the Eclipse formatter because download.eclipse.org failed DNS resolution.
  • JAVA_HOME=${JAVA_HOME_11} ./gradlew -Porg.gradle.java.installations.paths=${JAVA_HOME_25} clean build -x spotlessCheck passed. XML totals: core-api test/testJdk25 each 607; core-api-java6 test/testJdk25 each 608; zero failures/errors/skips. Compilation, jars, example packaging, Animal Sniffer and coverage verification passed.
  • Exact-head Actions run 43972503520, build job 133668014372: completed/success. Workflow runs ./gradlew -Porg.gradle.java.installations.fromEnv=JAVA_HOME_25_X64 clean build, formatting included. Runs/jobs and commit-status APIs checked; no commit statuses are posted (the empty aggregate is not a pending job). No material unfinished check identified.
  • git diff --check 853feb3 HEAD passed. Pinned introduced_blobs.py completed: five content writes across two commits, all corresponding to the intentional five source paths. Content and diffs inspected; no credential, scratch artifact or historical-only file found.

Passes (non-blocking): run: documentation correctness (version examples and removed prose), tests/CI/packaging (three test files touched, shared generation and build checked), cross-cutting simplicity, comment hygiene, diff composition. Not run: core runtime/API/security/data (no executable change); dedicated error specialist (only comments/Javadoc, no changed failure behavior or messages); deployment/operations/observability (no manifests, operational procedures or telemetry changes); shared-component/frontend blast radius (no frontend files); behavior-bearing data/policy (no consumed configuration, fixtures or policies changed). Small comment-only scope audited locally; no independent specialist pass triggered.

Comment hygiene (non-blocking): 2 comment / 0 code lines, ratio n/a; none flagged.
threshold T=5; restatements counted: yes (10 × C ≥ E).
Both added lines are one-line public-method documentation, preserved by the documentation-string exemption. All five Java paths are source-class; no countable code added.

Diff composition (non-blocking): every file is required for the change; none flagged.

Simplifications (non-blocking): none. No construct or machinery introduced.

@joalves

joalves commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Final independent sdk-review on c066ba9: APPROVE

Independent sdk-review on c066ba9: APPROVE, 0 P1/P2 fixed across 1 reviewer pass.

A fresh subagent ran the sdk-review skill read-only on the full diff 853feb3..c066ba9. It got only the repo path, the base and head SHAs and the PR goal, not any earlier reviews. It found no P1, P2 or P3 findings, so nothing needs fixing and nothing new was pushed. Head stays c066ba9, the head Jervasion approved, and CI is green on it.

Sev Title Evidence Fixed in
— None evidence log steps 2, 4, 7 —

Two notes the reviewer raised that are not findings for this PR: the CHANGELOG heading ## 1.9.0 (unreleased) predates this PR and should be dated in a separate release-notes change; and the removed test comments carried §4.x spec references (removed as the approving reviewer asked).

Full reviewer report and evidence log (head c066ba9)

APPROVE at c066ba9: a comment-and-Javadoc-only change. Production and test bytecode are identical to the merge base and to the published 1.9.0 jars, both suites pass on JDK 11 and 25, CI (including Spotless) is green on this exact head, and the removed comments leave no contract untested (15 of 15 mutants killed).

Compared Maven Central com.absmartly.sdk:core-api / core-api-java6 1.9.0 (latest published; -sources.jar equals tag v1.9.0 except for the build-generated SdkVersion.java; tag v1.9.0 main code equals the merge base) → merge base 853feb3 (= tag v1.9.0) → head c066ba9. Parity with javascript-sdk and cross-sdk-tests: not applicable, because no behaviour changed (shown by bytecode identity). Only this PR's delta counts as a finding.

Must fix

None.

Tests needed (current implementation correct)

15 full-suite mutations on the system-attribute and publish code that the de-commented tests cover: 15 killed, 0 survived. Each of the 16 removed comments described a test whose assertions still kill the matching mutant (see the evidence log, step 4).

Compatibility / parity / forward-compat evidence

  • javap -public -s on all 133 core-api and 135 core-api-java6 classes: the published 1.9.0 jar, the base and head are identical.
  • javap -p -c -constants with line-number tables stripped: production code is identical across release, base and head for both artifacts. All 81 core-api test classes are identical between base and head. So no API, binary or behaviour change, and no forward-compat surface touched.
  • Bytecode floors are unchanged: core-api-java6 major 50, core-api major 52.

Performance

Not applicable: the bytecode is identical. No timing claimed.

P3 / notes

  • Note (not a finding): the removed test comments carried §4.x cross-references to the system-attributes spec, and one named the customer regression it pins. The test names still describe the behaviour, so traceability to the spec section numbers is the only thing lost. The approving reviewer asked for the removal, so leave it.
  • The Client.java:219,224 Javadoc now says 1.9.0, which matches build.gradle VERSION = "1.9.0". No other stale 1.7.0/1.8.0 agent strings in code or Javadoc (the remaining hits are the README "Upgrading to 1.8.0" section and historical plan docs, which are correct as written).

Version and release notes

build.gradle VERSION 1.9.0 = the published 1.9.0 = the CHANGELOG 1.9.0 heading. (The heading still reads "(unreleased)" although 1.9.0 is on Maven Central. That is pre-existing, see below.) This PR changes nothing customer-visible, so it correctly adds no CHANGELOG entry and does not touch CHANGELOG, README or build.gradle.

Pre-existing on main (not this PR)

  • origin/main (07807b5) is 63 commits ahead of the merge base (switchback phase 1b, feat(switchback): serve R33 cluster-defined switchbacks #15). That work is not part of this PR's delta and was not reviewed here. The PR is MERGEABLE.
  • The CHANGELOG heading ## 1.9.0 (unreleased) was not dated although 1.9.0 is published on Maven Central (tag v1.9.0 = 853feb3). Track this separately as a release-notes fix.

Verification limits / provenance: Spotless could not run locally (download.eclipse.org does not resolve). CI run 43972503520 on head c066ba9 (./gradlew clean build, JDK 11 + 25 lanes, which includes spotlessCheck) succeeded. The following were not run because bytecode identity makes them redundant: the external consumer probe, the behaviour sweep, JS parity vectors, cross-sdk-tests, perf and forward-compat injection. All counts come from the JUnit XML in the scratch worktrees.


sdk-review evidence: #24

  • Head: c066ba999277dcfcc7971fd210915434abb6f791 (gh pr view 24 --json headRefOid = same)
  • Mode: independent reviewer (local, read-only)
  • Previous pass / review: none for chore: follow-ups from the #22 approvals #24. Commits base..head: f460899 (docs: Client Javadoc 1.9.0), c066ba9 (test: drop restating comments)
  • Started / finished (UTC): 2026-11-18 09:35 / 09:55
  • Scratch: /tmp/sdkrev.LMva (worktrees base=853feb3, head=c066ba9, mut=c066ba9; removed afterwards)

1. Trees

Tree Identifier How obtained Verified
Released Maven Central core-api 1.9.0, core-api-java6 1.9.0 (metadata <release>1.9.0</release>) curl repo1.maven.org/.../maven-metadata.xml; downloaded jar and -sources.jar diff -r sources jar vs git archive v1.9.0 core-api/src/main/java: identical except the generated SdkVersion.java; public API and code of both jars identical to head (step 2)
Main / merge base 853feb3 git merge-base origin/main c066ba9 = tag v1.9.0 (git log -1 v1.9.0); git diff --quiet v1.9.0 853feb3 -- core-api/src/main core-api-java6 build.gradle gradle → no diff
Head c066ba9 git rev-parse HEAD, gh headRefOid
Version source / X-Agent / CHANGELOG heading agree: yes (build.gradle VERSION "1.9.0"; Javadoc examples 1.9.0; CHANGELOG ## 1.9.0 (unreleased), pre-existing label)

2. Backwards compatibility

  • git diff --stat 853feb3..c066ba9: 5 files, +2/-23. Every hunk is a comment or Javadoc line (read in full).
  • API diff: javap -public -s over every class (release jar, base build, head build), compared with cmp → core-api 133 classes identical, core-api-java6 135 classes identical (release == base == head).
  • Bytecode: javap -p -c -constants, LineNumberTable/line entries stripped → release == base == head for both artifacts; core-api test classes (81) base == head.
  • Consumer probe / released tests vs head / behaviour sweep / error contract: NOT RUN, redundant because the production bytecode is identical to the published jar.
  • Public fields/hooks whose effect changed: none (identical bytecode).
  • Entry points: n/a.

3. Parity

  • NOT RUN: no behaviour delta (identical bytecode). cross-sdk-tests: n/a.

4. Tests and mutation

  • Full suite, JAVA_HOME=$JAVA_HOME_11 LC_ALL=C.UTF-8 ./gradlew --no-daemon clean build -x spotlessCheck, exit 0 on both trees:
    • base: core-api test 607/0 fail/0 skip, testJdk25 607/0/0; core-api-java6 test 608/0/0, testJdk25 608/0/0
    • head: identical counts (core-api 607/607 JDK11/JDK25, java6 608/608, 0 failures, 0 skipped)
  • Mutants, applied one at a time to core-api Context.java in the mut worktree; full :core-api:test (607 tests) each time; script /tmp/sdkrev.LMva/scripts/mut.py
    | # | Mutant | Killed by (sample) | Result |
    |---|---|---|---|
    | 1 | environment removed from eval map | 9 tests incl. systemAttributesInRuleConditions, evaluationUsesSystemAttributesRegardlessOfFlag | killed |
    | 2 | application removed from eval map | 6 incl. strictAudienceOnApplicationMatches, LocalHttpServerIntegrationTest[1],[2] | killed |
    | 3 | empty application/environment injected as "" | missingApplication/EnvironmentLeavesKeyOutOfMap | killed |
    | 4 | system attrs override user attrs | 6 incl. userSetEnvironmentWinsSetAfterCreation, userEnvironmentAttributeDoesNotChangeRuleScope | killed |
    | 5 | app_version "9.9.9" injected into eval map | appVersionIsNotARuleCondition, appVersionIsNotAnAudienceVariable (+2) | killed |
    | 6 | eval system attrs gated on includeSystemAttributes | 9 incl. evaluationUsesSystemAttributesRegardlessOfFlag | killed |
    | 7 | publish adds environment when flag on | publishPrependsOnlySdkAttributesWhenEnabled, LocalHttpServerIntegrationTest[2] (+2) | killed |
    | 8 | publish adds environment by default | publishAddsNothingByDefault, LocalHttpServerIntegrationTest[1] (+5) | killed |
    | 9 | sdk_version dropped from publish | 6 incl. publishPrependsOnlySdkAttributesWhenEnabled | killed |
    | 10 | user-set name dedup removed | publishSkipsSdkAttributesTheUserSet | killed |
    | 11 | no audience recheck after setAttribute | invalidatesAssignmentCachedBeforeUserSetEnvironment (+1) | killed |
    | 12 | getAttributes reports environment | systemAttributesAreNotReportedAsUserAttributes | killed |
    | 13 | rule scope read from user environment attr | userEnvironmentAttributeDoesNotChangeRuleScope | killed |
    | 14 | system attr setAt = publishedAt (not earliest event) | publishStampsSystemAttributesWithEarliestEvent (+1) | killed |
    | 15 | production environment wiring blank (real factory) | 11 incl. matchesRuleForEnvironment | killed |
    Totals: 15 run / 15 killed / 0 survived. The mut worktree was restored and git status --short was empty.
  • Fix-commit audit: f460899 and c066ba9 add no state (no flags, stamps, caches, wiring or public names). They only delete comments and change two Javadoc strings.
  • Test hygiene of the touched tests: unchanged bytecode, so no new sleeps, waits or vacuous asserts.

5. Performance

  • NOT RUN / n/a: identical production bytecode. No timing claimed.

6. Forward compatibility

  • NOT RUN / n/a: the decoder and models are unchanged (identical bytecode).

7. Build / CI

  • Package build: ./gradlew clean build -x spotlessCheck (JDK 11 toolchain; testJdk25 lane included) → exit 0 on head; jars core-api.jar, core-api-java6.jar built. Animal Sniffer and JaCoCo ran in build.
  • Floors: core-api-java6 Client.class major 50 (release 50), core-api major 52. Unchanged.
  • Newest runtime: testJdk25 lane passes (see step 4).
  • Spotless locally: ./gradlew spotlessCheck → NOT RUN (UnknownHostException download.eclipse.org).
  • CI on this exact head: gh run view 43972503520 → headSha c066ba9…, conclusion success, job build ("Setup Java 25 and 11", "Build Java SDK" = ./gradlew ... clean build, which includes spotlessCheck) success. CodeRabbit check pass.
  • Pins: none touched.

8. Docs / CHANGELOG

  • Section/version: no CHANGELOG change, which is correct for a change with no customer-visible effect. The 1.9.0 heading is still "(unreleased)" although 1.9.0 is published (pre-existing).
  • Migration notes: n/a (no API delta vs published 1.9.0).
  • Stale strings: git grep -n '1\.7\.0\|1\.8\.0' c066ba9 -- '*.java' '*.md' '*.gradle' (excl. CHANGELOG) → only README "Upgrading to 1.8.0" (correct) and docs/plans history. git grep 'absmartly-java-sdk/1' → only Client.java:224 (1.9.0). No orphaned §4/Serko references left in core-api.

Findings

Sev Title Evidence line above Fixed in
— None steps 2, 4, 7 —

Verification limits

  • Spotless not run locally (no network to download.eclipse.org); covered by CI run 43972503520 on c066ba9.
  • Consumer probe, behaviour sweep, JS parity, cross-sdk-tests, perf, forward-compat: not run, redundant given byte-identical production code vs the published 1.9.0 jars.

🤖 Generated with Claude Code

@marcio-absmartly marcio-absmartly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE. Reviewed the complete diff at c066ba9992. The only non-comment text changes update the Javadoc version examples from 1.7.0 to 1.9.0; all other edits remove explanatory comments. No executable code, signatures, test assertions or fixtures change. This closes the comment/version-example follow-ups without affecting the prior SDK review's behaviour or compatibility conclusions.

Validation: complete source diff review; GitHub build is green on this head. I did not rerun the suite locally for this comment/Javadoc-only change.

@joalves
joalves merged commit 9b2414b into main Nov 20, 2026
2 checks passed
joalves pushed a commit that referenced this pull request Nov 20, 2026
Takes main's #24 follow-ups (restating test comments removed). The 1.x Client agent Javadoc
change does not apply: 2.x removed getAgent/getAgentName/getAgentVersion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants